Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hard dependency of InventoryCatalog on Inventory module #1168

Merged

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented May 16, 2018

Description

Fixed hard dependency of InventoryCatalog on Inventory module.

Fixed Issues (if relevant)

  1. Fix hard dependency of InventoryCatalog on Inventory module #1151: Fix hard dependency of InventoryCatalog on Inventory module

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link

magento-cicd2 commented May 16, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dmytro-ch
❌ maghamed

@maghamed
Copy link
Contributor

@dmytro-ch you have red static build because of module sequence, which is not needed anymore and can remove

    <module name="Magento_InventoryCatalog" setup_version="1.0.0" >
        <sequence>
            <module name="Magento_Inventory"/>
        </sequence>
    </module>

@dmytro-ch
Copy link
Contributor Author

@maghamed thank you.
I've removed a sequence.

@maghamed maghamed merged commit 8bdccb1 into 2.3-develop May 21, 2018
@maghamed maghamed deleted the 1151-fix-hard-dependency-inventory-catalog-on-inventory branch March 20, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants