Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distance based source selection algorithm #1866

Merged
merged 75 commits into from
Jan 21, 2019
Merged

Distance based source selection algorithm #1866

merged 75 commits into from
Jan 21, 2019

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Nov 2, 2018 •
edited by maghamed
Loading

Distance based source selection algorithm

#1991

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@phoenix128 phoenix128 force-pushed the distance-based-source-selection-algorythm branch 2 times, most recently from 7400b71 to 58dd9cb Compare November 2, 2018 13:45
@phoenix128 phoenix128 changed the title WIP: Distance based source selection algorithm Distance based source selection algorithm Nov 2, 2018
@phoenix128
Distance based source selection algorithm
cbb768b 
A basic google map implementation is provided
@phoenix128
FIX broken configuration reading with api key
77dfac6
@phoenix128
Offline distance provider
d0db136
@phoenix128
Missing country filter
a06785d
@phoenix128
Rework: virtual model for Distance Providers definition
e71cbac
@phoenix128
WIP inventory request builder
89e908e
@phoenix128
InventoryRequest builder refactor
b1fc15c
@phoenix128
Removed old unused class
0952dd6
@phoenix128
Removed invalid length attribute
053e212
@phoenix128
CS fix
acdf2fb
@phoenix128
Distance providers naming change
a3eab58
@phoenix128
Geo reference provider rework
e20fc5d
@phoenix128
Moved request builders to API
3ef659b
@phoenix128
Removed api tag from non-api interfaces
8dee924
@phoenix128
Removed accidental dependency
1e87018
@phoenix128
Removed dependencies with module-sales
4c93505
@phoenix128
FIX accidental removal of use Magento\Sales\Api\Data\OrderItemInterface
6237351
@phoenix128
Removed redundant dependencies
8b82ea9
@phoenix128
Added module-inventory-source-selection-admin-ui to composer.json
09af925
@phoenix128
FIX coupling between objects
e507596
@phoenix128 phoenix128 force-pushed the distance-based-source-selection-algorythm branch from 12a8b72 to e507596 Compare November 23, 2018 00:05
@lorikrell
Copy link

lorikrell commented Nov 30, 2018 •
edited
Loading

@phoenix128
Error Question: I didn't enter a Google API key and tried using the Distance SSA for a shipment. I received this error:

A technical problem with the server created an error. Try again to continue what you were doing. If the problem persists, try again later.

Is this an error message for any issue that occurs in MSI?
Specific to not detecting the API key?
Specific to the Distance SSA?

Recommendation, but may need to be edited further depending on scenario:

A technical issue occurred. Verify your store configuration settings, and try applying the Source Selection Algorithm again.

(maybe also with a link to the Stores > Configuration > Inventory page for store configuration?)

Also would the troubleshooting be:

  • Verify your Google API key and settings in Google
  • Could a server/other issue be happening? If so, what might those be, anything they can do or just wait and try again?

Also would you like a documentation link for error messages/troubleshooting? I plan on covering troubleshooting in the docs.

lorikrell
lorikrell reviewed Nov 30, 2018
View reviewed changes
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entered a review on the Store > Configuration text.

app/code/Magento/InventorySourceSelectionAdminUi/etc/adminhtml/system.xml Outdated Show resolved Hide resolved
@phoenix128
Update app/code/Magento/InventorySourceSelectionAdminUi/etc/adminhtml…
ce4be4f 
…/system.xml

Co-Authored-By: phoenix128 <riccardo.tempesta@gmail.com>
@magento-cicd2
Copy link

magento-cicd2 commented Dec 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

IvanPletnyov added a commit that referenced this pull request Jan 18, 2019
@IvanPletnyov
Fix static tests on pull request #1866
f72db94 
(#1866)
@IvanPletnyov IvanPletnyov mentioned this pull request Jan 18, 2019
Closed
IvanPletnyov added a commit that referenced this pull request Jan 18, 2019
@IvanPletnyov
Fix static tests on pull request #1866
6b5356d 
(#1866)
@maghamed
Copy link
Contributor

maghamed commented Jan 18, 2019 •
edited
Loading

User Requested:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12329/

UR Acceptance:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12330/

Existing PR:
https://m2build.devops.magento.com/job/Existing-PR-Tests/11290/

Existing PR 2.3-develop
https://m2build.devops.magento.com/job/Existing-PR-Tests/11291/

@maghamed
Copy link
Contributor

maghamed commented Jan 19, 2019 •
edited
Loading

Jenkins on PR
https://m2build.devops.magento.com/job/Existing-PR-Tests/11303/

2.3-develop:
https://m2build.devops.magento.com/job/Existing-PR-Tests/11304/

UR Jenkins:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12337/

https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/12338/

@maghamed maghamed merged commit ab5d971 into 2.3-develop Jan 21, 2019
@ghost
Copy link

ghost commented Jan 21, 2019

Hi @phoenix128, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ishakhsuvarov ishakhsuvarov deleted the distance-based-source-selection-algorythm branch June 19, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorikrell lorikrell lorikrell left review comments

@maghamed maghamed maghamed requested changes

Assignees
No one assigned
Labels
Award: advanced Award: complex Award: special achievement Award: test coverage Partner: MageSpecialist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@phoenix128 @lorikrell @magento-cicd2 @smoskaluk @maghamed @Stepa4man @magento-engcom-team @IvanPletnyov