Msi 2035 storepickup #2036
Msi 2035 storepickup #2036
Conversation
|
|
| @@ -0,0 +1,25 @@ | |||
| # InventoryInStorePickupApi module | |||
|
|
|||
| The `InventoryInStorePickupApi` module provides Inventory Management service contracts. | |||
There was a problem hiding this comment.
provides service contracts for In-Store Pickup functionality
| ## Extensibility | ||
|
|
||
| The `InventoryInStorePickupApi` module contains extension points and APIs that 3rd-party developers | ||
| can use to provide custom inventory source selection algorithm functionality. |
There was a problem hiding this comment.
to provide custom inventory source selection algorithm functionality.
instead of " custom inventory source selection algorithm functionality."
it should be something like - customization of In Store Pickup functionality
| @@ -0,0 +1,24 @@ | |||
| # InventoryInStorePickupAdminUi module | |||
|
|
|||
| The `InventoryInStorePickupAdminUi` module provides Inventory Management service contracts. | |||
There was a problem hiding this comment.
Should be rephrased to something like "... extends the Magento Admin UI to add Inventory In Store Pickup functionality."
| @@ -0,0 +1,17 @@ | |||
| # InventoryInStorePickup module | |||
|
|
|||
| The `InventoryInStorePickup` module provides Inventory Management service contracts. | |||
There was a problem hiding this comment.
provides service contracts for In-Store Pickup functionality
| "description": "N/A", | ||
| "require": { | ||
| "php": "~7.1.3||~7.2.0", | ||
| "magento/framework": "*" |
There was a problem hiding this comment.
please add the dependences.
"magento/module-inventory-in-store-pickup-api": "*", "magento/module-backend": "*", "magento/module-directory": "*", "magento/module-ui": "*"
There was a problem hiding this comment.
@TadeuRodrigues Test fails due to:
3) Magento\Test\Integrity\DependencyTest::testRedundant
Redundant dependencies found!
Module Magento\InventoryInStorePickup: hard [Magento\InventoryInStorePickupApi]
Module Magento\InventoryInStorePickupAdminUi: hard [Magento\Backend, Magento\Directory, Magento\InventoryInStorePickupApi, Magento\Ui]
michaelwylde
force-pushed
the
msi-2035-storepickup
branch
from
4b25f54 to
c3db14c
Compare
michaelwylde
force-pushed
the
msi-2035-storepickup
branch
from
c3db14c to
fbab88a
Compare
…ento-engcom/msi into msi-2035-storepickup Conflicts: composer.lock
|
We are looking to continue development of the Store Pickup feature in a separate branch for now, so I have updated this Pull Request with latest |
|
Hi @michaelwylde, thank you for your contribution! |
Created base modules for In Store Pickup - 2035
Description
Base modules to be used for In Store Pickup
Fixed Issues (if relevant)