#207 - Move Qty product import processing to new stock item importer #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2017 17:10
josh-carter
changed the title
added 5 commits
November 19, 2017 13:34
- is_in_stock is not required for import, add check to see if isset, use 0 if not
josh-carter
changed the title
added 4 commits
November 20, 2017 08:52
- Also removes unused delete interface from class declaration
josh-carter
changed the title
maghamed
reviewed
Nov 21, 2017
| @@ -778,6 +787,7 @@ public function __construct( | |||
| Product\TaxClassProcessor $taxClassProcessor, | |||
| \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, | |||
| \Magento\Catalog\Model\Product\Url $productUrl, | |||
| StockItemImporterInterface $stockItemImporter, | |||
There was a problem hiding this comment.
currently adding required dependency will introduce Backward Incompatible changes.
It's better to do like we usually do to preserve constructor BC :
public function __construct(
\\old arguments
StockItemImporterInterface $stockItemImporter = null //add new dependency at the end of the dependencies list
) {
$this->stockItemImporter = $stockItemImporter ?: \Magento\Framework\App\ObjectManager::getInstance()->get(
StockItemImporterInterface::class
);
- By not requiring stockItemInterface in construct
maghamed
reviewed
Nov 21, 2017
| /** | ||
| * Source Item Importer | ||
| * | ||
| * @var |
There was a problem hiding this comment.
please specify data type for @var StockItemImporterInterface
There was a problem hiding this comment.
Good spot - fixed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move Qty Importing to new Stock Item Importer, new extension point to allow for eventual move of product stock import logic to here.
Fixed Issues (if relevant)
#207
Outstanding Tasks