Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Increase InventoryGraphql test coverage #2177

Merged
merged 5 commits into from
Jun 20, 2019
Merged

[WIP] Increase InventoryGraphql test coverage #2177

merged 5 commits into from
Jun 20, 2019

Conversation

eugene-shab
Copy link
Contributor

@eugene-shab eugene-shab commented Apr 13, 2019 •
edited by nmalevanec
Loading

@magento-cicd2
Copy link

magento-cicd2 commented Apr 13, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@maghamed
Copy link
Contributor

maghamed commented Apr 19, 2019 •
edited
Loading

hey @eugene-shab any updates on this one?

currently, we have one test broken

There was 1 failure:
1) Magento\InventoryGraphQl\Test\Api\ProductStockStatusTest::testQueryProductStockStatusInStockWithSources
Failed asserting that an array has the key 0.
/home/travis/build/magento-engcom/msi/app/code/Magento/InventoryGraphQl/Test/Api/ProductStockStatusTest.php:47

@nmalevanec nmalevanec force-pushed the 2159_Increase_InventoryGraphql_test_coverage branch from 390f118 to 875647e Compare June 7, 2019 15:21
@Nazar65
Copy link
Member

Nazar65 commented Jun 14, 2019 •
edited
Loading

HI all, current test fails due to magento/graphql-ce#167 , there is no ability to set
@magentoConfigFixture default_store cataloginventory/options/stock_threshold_qty 99 with provided changes in related PR magento/graphql-ce#351 all test are green.

@Nazar65 Nazar65 force-pushed the 2159_Increase_InventoryGraphql_test_coverage branch 3 times, most recently from e11ed45 to aaf6dc8 Compare June 15, 2019 07:09
@nmalevanec nmalevanec force-pushed the 2159_Increase_InventoryGraphql_test_coverage branch from aaf6dc8 to 2f2dc3e Compare June 20, 2019 11:13
@nmalevanec nmalevanec force-pushed the 2159_Increase_InventoryGraphql_test_coverage branch from 2f2dc3e to a163d16 Compare June 20, 2019 11:44
@ishakhsuvarov ishakhsuvarov merged commit b30578e into 2.3-develop Jun 20, 2019
@ishakhsuvarov ishakhsuvarov added Auto-Tests: Covered All changes in Pull Request are covered by auto-tests Award: test coverage labels Jun 20, 2019
@ishakhsuvarov ishakhsuvarov deleted the 2159_Increase_InventoryGraphql_test_coverage branch August 21, 2019 19:44
@ishakhsuvarov ishakhsuvarov mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishakhsuvarov ishakhsuvarov ishakhsuvarov approved these changes

Assignees
No one assigned
Labels
Auto-Tests: Covered All changes in Pull Request are covered by auto-tests Award: test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eugene-shab @magento-cicd2 @maghamed @Nazar65 @ishakhsuvarov @okorshenko @nmalevanec