MSI-2210: Price Indexer fails with large catalogs #2336
Conversation
...ntoryCatalog/Plugin/CatalogInventory/Model/Indexer/ModifySelectInProductPriceIndexFilter.php
Show resolved
Hide resolved
|
@Stepa4man you need also sign the new CLA best regards, |
@larsroettig licence/cla's will be imported from the old MSI project. |
|
@Stepa4man @larsroettig Thank you for your patience. CLA signatures were now transferred from the old repository and updated accordingly. |
| @@ -84,7 +94,7 @@ public function aroundModifyPrice( | |||
| $select->from(['price_index' => $priceTable->getTableName()], []); | |||
| $priceEntityField = $priceTable->getEntityField(); | |||
|
|
|||
| if ($this->resourceConnection->getConnection()->isTableExists($stockTable)) { | |||
| if (!$this->isDefaultStock($stock) && $this->resourceConnection->getConnection()->isTableExists($stockTable)) { | |||
| $select->joinInner( | |||
There was a problem hiding this comment.
Looks like this join should remain regardless of stock
There was a problem hiding this comment.
@ishakhsuvarov This join was done for getting SKU from catalog_product_entity and using it for joining inventory_stock_% table because it doesn't have product_id.
We don't need sku if we use cataloginventory_stock_status because it has product_id
Do you see any other reason?
| $select->joinLeft( | ||
| ['stock_status' => $legacyStockTableName], | ||
| sprintf( | ||
| 'stock_status.product_id = price_index.%s and stock_status.website_id = %d', |
There was a problem hiding this comment.
Website ID is also added later. Should we just join on sku in inventory and product?
…thub.com:magento-engcom/msi into MSI-2210-Price-Indexer-fails-with-large-catalogs
ishakhsuvarov
deleted the
MSI-2210-Price-Indexer-fails-with-large-catalogs
branch
…th-large-catalogs MSI-2210: Price Indexer fails with large catalogs
Fixed Issues
Manual testing scenarios
Described in issue
Contribution checklist