MSI-2522: Introduce yielding for order list iterations and use paging #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimjustus
changed the title
vadimjustus
changed the title
Stepa4man
suggested changes
Oct 8, 2019
| */ | ||
| public function getOrderIncrementId(): string | ||
| { | ||
| return (string)$this->orderIncrementId; |
| @@ -25,7 +25,7 @@ public function execute(array $inconsistencies): array | |||
| return array_filter( | |||
| $inconsistencies, | |||
| function (SalableQuantityInconsistency $inconsistency) { | |||
| return (bool)$inconsistency->getOrder(); | |||
| return $inconsistency->hasAssignedOrder() !== false; | |||
There was a problem hiding this comment.
Please get rid of !== false
| yield $item->getEntityId() => $item; | ||
| } | ||
|
|
||
| gc_collect_cycles(); |
|
Closing, as #2578 includes these changes |
ishakhsuvarov
deleted the
MSI-2522-consistency-cli-mem-usage-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce yielding for order iterations to improve memory usage.
Description (*)
Extends
GetOrdersInFinalStateandGetOrdersInNotFinalStateclasses in order to return\Traversablewhile usingyield.Test results with 1255 orders:
Fixed Issues (if relevant)
Manual testing scenarios (*)
2.3-developbranchbin/magento inventory:reservation:list-inconsistenciesMSI-2522-consistency-cli-mem-usage-improvementsbranchbin/magento inventory:reservation:list-inconsistenciesContribution checklist (*)