Source Management API #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inventory-api module
…rceExtensionInterface as it will be autogenerated
…ento2 into mni/source-management
…part of the businessmodel for source
…gcom/magento2 into mni/source-management
…ento2 into mni/source-management
- fixed code style issues
…llow the inherit doc from interface
…ento2 into mni/source-management
…part of the businessmodel for sourcecarrierlink, updated carrierlink-interface, implemented part of source-businessmodel
okorshenko
suggested changes
May 20, 2017
| @@ -322,15 +322,16 @@ public function setPriority($priority) | |||
| */ | |||
| public function getCarrierLinks() | |||
| { | |||
| // TODO: Implement getCarrierLinks() method. | |||
| return $this->getData(SourceInterface::PRIORITY); | |||
There was a problem hiding this comment.
Should it be a SourceInterface::CARRIER_LINKS ?
…gcom/magento2 into mni/source-management
| */ | ||
| public function setPriority($priority); | ||
|
|
||
| /** | ||
| * @param \Magento\InventoryApi\Api\Data\SourceCarrierLinkInterface[] $carrierLinks | ||
| * @return $this | ||
| * @return \Magento\InventoryApi\Api\Data\SourceCarrierLinkInterface[] |
There was a problem hiding this comment.
null may be returned as well
-- global refactoring
| /** | ||
| * Collection constructor | ||
| * | ||
| * @param SourceCarrierLinkManagementInterface $sourceCarrierLinkManagement |
There was a problem hiding this comment.
Please update phpdoc with all dependencies
-- global refactoring -- fix unit tests
-- fix static tests
-- fix static tests -- fix soap tests
-- fix static tests
-- global refactoring
-- global refactoring
-- global refactoring
-- fix static tests
-- fix static tests
…nto/magento2ce into mni/source-management
-- fix static tests
This was referenced Dec 11, 2017
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 15, 2020
B2B-1026: Purchase Order final checkout page is incompatible with msi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes which were created during the 1st contribution day in Leipzig
Fixed Issues (if relevant)
source_edit(approved by @maghamed)Manual testing scenarios
Currently code review only
Contribution checklist