MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup. #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ducts-is-not-available-for-pickup. Create API declaration.
added 2 commits
February 22, 2020 19:17
…ducts-is-not-available-for-pickup. Add draft implementation.
…ducts-is-not-available-for-pickup. Add implementation for search intersection of pickup locations for requested product info. Change interfaces implementation - add ProductInfoInterface.
novikor
suggested changes
Feb 24, 2020
InventoryInStorePickupShipping/Model/ResourceModel/GetPickupLocationIntersectionForSkues.php
Outdated
Show resolved
Hide resolved
InventoryInStorePickupShipping/Model/ResourceModel/GetPickupLocationIntersectionForSkues.php
Outdated
Show resolved
Hide resolved
InventoryInStorePickupShipping/Model/GetAvailableLocationsForPickup.php
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
…ducts-is-not-available-for-pickup. Apply code review changes.
…er-submissions-if-one-of-the-products-is-not-available-for-pickup
…ducts-is-not-available-for-pickup. Add api-functional tests coverage.
…one-of-the-products-is-not-available-for-pickup' of github.com:magento/inventory into MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup
…er-submissions-if-one-of-the-products-is-not-available-for-pickup
novikor
added
Auto-Tests: Covered
novikor
previously approved these changes
Mar 4, 2020
…ducts-is-not-available-for-pickup. Remove plugin - move logic to the chain. Migrate tests to the new module.
…one-of-the-products-is-not-available-for-pickup' of github.com:magento/inventory into MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup
…ducts-is-not-available-for-pickup. Add missed param. Move extension attributes to API module.
…ducts-is-not-available-for-pickup. Remove extension attributes from filter group. Add extension attributes to search request.
…ducts-is-not-available-for-pickup. Revert pathes in tests.
…er-submissions-if-one-of-the-products-is-not-available-for-pickup
…ducts-is-not-available-for-pickup. Fix static tests.
…one-of-the-products-is-not-available-for-pickup' of github.com:magento/inventory into MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup
sidolov
requested changes
Mar 9, 2020
InventoryInStorePickup/Model/ResourceModel/GetPickupLocationIntersectionForSkus.php
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
…ducts-is-not-available-for-pickup. Add missed return type.
added 2 commits
March 12, 2020 13:08
…store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup
sidolov
approved these changes
Mar 12, 2020
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
sidolov
deleted the
MSI-2826-Hide-store-pickup-during-order-submissions-if-one-of-the-products-is-not-available-for-pickup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
#2826
Fixed Issues (if relevant)