Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1389 :- Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" #2868

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

konarshankar07
Copy link
Contributor

@konarshankar07 konarshankar07 commented Mar 9, 2020

Description (*)

This PR will add the tooltip for the additional information regarding salable product quantity

Fixed Issues (if relevant)

  1. Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" #1389: Add tooltip to Product grid as well as Product page describing what is "Salable Quantity"

Manual testing scenarios (*)

  1. Login to Magento Admin
  2. Go to Store -> Configuration
  3. Expand Catalog menu from left sidebar list
  4. Click on "Products"
  5. Add new product or Edit the existing product from the grid
  6. Scroll down and look for "Product Salable Quantity"

Expected Result

image

image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@konarshankar07 konarshankar07 changed the title #1389 :- Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" [WIP]:- #1389 :- Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" Mar 9, 2020
@konarshankar07 konarshankar07 requested a review from sidolov March 9, 2020 12:12
@konarshankar07
Copy link
Contributor Author

Hello @sidolov ,
As per ticket, We also need to add the tooltip in product grid. Can you please check the below screenshot and let me know if its okay or not? Personally, I don't think we need to add the tooltip in the grid
image
Thanks

@sidolov
Copy link
Contributor

sidolov commented Mar 9, 2020

@konarshankar07 agree with you, tooltip in the grid is redundant, let's add it to the product form only. Thank you for your feedback!

sidolov
sidolov previously approved these changes Mar 9, 2020
@sidolov sidolov changed the title [WIP]:- #1389 :- Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" #1389 :- Add tooltip to Product grid as well as Product page describing what is "Salable Quantity" Mar 10, 2020
@sidolov sidolov merged commit 95104be into 1.2-develop Mar 12, 2020
@sidolov sidolov deleted the tooltip-for-salable-qty--task-1389 branch March 12, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants