Task 290 import export source code #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2017 15:05
- Adapted SourceItem Import/Export to use Source Code instead of SourceId; - Fixed issue when in Stock Sources export process all fields ware excluded; - Fixed type of return value for SourceItem->getSourceId method to int(was string); - Adapted integrational test to the new Export/Import system(with source code).
…ask-290-import-export-source-code Conflicts: app/code/Magento/InventoryApi/Test/_files/source.php app/code/Magento/InventoryApi/Test/_files/sources.php
- Fixed integration test.
- Fixed DependencyTest error.
maghamed
reviewed
Dec 15, 2017
| @@ -48,7 +48,7 @@ public function setSku($sku) | |||
| */ | |||
| public function getSourceId() | |||
| { | |||
| return $this->getData(self::SOURCE_ID); | |||
| return (int)$this->getData(self::SOURCE_ID); | |||
There was a problem hiding this comment.
It's not correct to cast to int here,
because when the factory creates SourceId there is no guarantee that factory will set something to SourceId
that's why PHP Doc says (@return int|null)
- Changed SourceItem->getSourceId method.
- MEQP2 fixes;
- modified Source Item database structure(source_id changed to source_code); - SourceId was replaced by SourceCode in MSI Extensions;
- source_id field usings ware replaced by source_code field - part;
- fixed foreign key issue with source_item_configuration setup schema; - tests fixes - part;
- Fixed setup schema script for creatind default source; - Tests fexes - part;
- fixed install schema/data issues; - fixed issues on Source grid; - identity field returned to source_id on Source mode;
…port-source-code Conflicts: app/code/Magento/Inventory/Controller/Adminhtml/Stock/StockSourceLinkProcessor.php
- Fixed issue with with incorrect query on product edit page;
- Fixed issue with source item UIcomponent on product edit page
…port-source-code Conflicts: app/code/Magento/InventoryApi/Test/_files/products.php
- Fixed issued with UI Components on stock edit page;
- Integration test fixes - part;
- Integration tests fixes - part;
- Test fixes -part;
- MEQP2 fixes; - SourceImportExport integration tests fixes - part; - Stock Source Import: modified sample file;
…om/magento-engcom/msi into task-290-import-export-source-code Conflicts: app/code/Magento/InventoryImportExport/Files/Sample/stock_sources.csv
|
Failed functional tests are related to |
naydav
approved these changes
Dec 27, 2017
This was referenced Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#290