-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source item management #36
source item management #36
Conversation
…i-lars work on region fields, system configuration of default carriers
class SourceItem extends AbstractExtensibleModel implements SourceItemInterface | ||
{ | ||
/** | ||
* @return int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sku int ? is string
} | ||
|
||
/** | ||
* @return int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status int? bool will better if true or false
} | ||
|
||
/** | ||
* @param SourceItemInterface $sourceItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inheritdoc documentation must define in the interface
throw new CouldNotSaveException(__('Could not save source item'), $e); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Docblock
return $sourceItem; | ||
} | ||
|
||
public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCriteria = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be implemented
|
||
} | ||
|
||
public function delete($sourceItemId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must be implemented
MC-39004: Update doc links
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist