386: Adapt \Magento\CatalogInventory\Helper\Stock::addStockStatusToProducts
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
reviewed
Jan 18, 2018
| AbstractCollection $productCollection | ||
| ) { | ||
| // We need to prevent the collection modification by plugins next in the chain. | ||
| $temporaryCollection = clone $productCollection; |
There was a problem hiding this comment.
We can not do it
Because it means that functionality in next plugins will be broken (will be applied on clone, but not on real collection)
# Conflicts: # app/code/Magento/InventoryCatalog/composer.json
naydav
approved these changes
Jan 25, 2018
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 16, 2023
ACPT-1643: Fix Inventory salable performance issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added around plugin to \Magento\CatalogInventory\Helper\Stock::addStockStatusToProducts and integration test.
Fixed Issues (if relevant)
\Magento\CatalogInventory\Helper\Stock::addStockStatusToProducts#386: Adapt\Magento\CatalogInventory\Helper\Stock::addStockStatusToProductsManual testing scenarios
Contribution checklist