Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI: Slight refactoring #63

Merged
merged 1 commit into from
Aug 22, 2017
Merged

MSI: Slight refactoring #63

merged 1 commit into from
Aug 22, 2017

Conversation

naydav
Copy link

@naydav naydav commented Aug 21, 2017

@maghamed
Copy link
Contributor

nice changes, all of them make sense for me.

What I propose to add is re-naming of SourceItemSaveInterface -> SourceItemsSaveInterface
as this service provides a possibility of saving Multi SourceItems per call, so that would be more semantically friendly to call it SourceItemsSaveInterface in plural form

@magento-cicd2
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@naydav
Copy link
Author

naydav commented Aug 22, 2017

Internal static build (INTEGRITY-SANITY-EE) is red due to MAGETWO-71596

@naydav naydav merged commit 52b8a35 into develop Aug 22, 2017
@maghamed maghamed deleted the refactoring branch December 11, 2018 18:12
mmansoor-magento pushed a commit that referenced this pull request Feb 4, 2021
[Arrows] MC-38546: Warnings in Unit tests build log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants