MSI: 654: Exception when trying to create Grouped or Bundle product in admin #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
reviewed
Mar 13, 2018
| $meta[ConfigurablePanel::GROUP_CONFIGURABLE][$children] | ||
| [ConfigurablePanel::CONFIGURABLE_MATRIX][$children] | ||
| [static::RECORD][$children][static::QUANTITY_CONTAINER] = $this->getQuantityContainerConfig(); | ||
| if ($this->allowedProductTypes->isAllowedProductType($this->locator->getProduct())) { |
There was a problem hiding this comment.
Why do we need to use this code for products different from configurable?
There was a problem hiding this comment.
Because simple, virtual and downloadable product can be converted to configurable.
There was a problem hiding this comment.
After moving InventoryConfigurablePanel we can remove this double check
# Conflicts: # app/code/Magento/InventoryConfigurableProduct/etc/di.xml
naydav
reviewed
Mar 14, 2018
| @@ -16,8 +18,27 @@ | |||
| */ | |||
| class InventoryConfigurablePanel extends AbstractModifier | |||
There was a problem hiding this comment.
Looks like we need to move this to modifier <type name="Magento\ConfigurableProduct\Ui\DataProvider\Product\Form\Modifier\Composite">
And remove AllowedProductTypes check
naydav
reviewed
Mar 14, 2018
| @@ -16,4 +16,9 @@ | |||
| </argument> | |||
| </arguments> | |||
| </virtualType> | |||
| <type name="Magento\InventoryConfigurableProduct\Ui\DataProvider\Product\Form\Modifier\InventoryConfigurablePanel"> | |||
There was a problem hiding this comment.
After moving InventoryConfigurablePanel we can remove this double check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues (if relevant)