FIX issue #33 - Returning void on method makes the whole class unable… #993
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unable to use plugins Void methods were breaking Interceptor classes because of the presence of a return statement. Return statements with any kind of value (even null) is forbiddent by PHP7.2 . Interceptor generation clas has been modified to check the void return type and unit tests have been adjusted accordingly.
|
Corresponding PR to Core: magento/magento2#14799 |
larsroettig
approved these changes
Apr 22, 2018
larsroettig
previously requested changes
Apr 22, 2018
|
@larsroettig , cannot fix in the MSI branch due to code freeze. Check magento#14799 PR. |
vadimjustus
dismissed
larsroettig’s stale review
The failing static tests are valid! Waiting for magento#14799
|
Merged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx for issue magento-engcom/php-7.2-support#33
Description
Void methods were breaking Interceptor classes due to a return statement.
PHP7.2 forbids the presence of a return statement with parameters in void methods, even if returning null.
Fixed Issues (if relevant)
Contribution checklist