Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 911 - Cannot read property source_code of undefined #997

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Apr 22, 2018

Dynamic data rows were failing due to a read after delete condition
Rows were removed just before the information update. An undefined javascript error was triggered.

Fixed Issues (if relevant)

  1. Cannot read property source_code of undefined #911: Cannot read property source_code of undefined

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Dynamic data rows were failing due to a read after delete condition
Rows were removed just before the information update. An undefined javascript error was triggered.
@naydav naydav merged commit 45f0c8c into magento:2.3-develop May 2, 2018
sidolov pushed a commit that referenced this pull request Oct 18, 2019
…sTypeResolver #997

 - Merge Pull Request magento/graphql-ce#997 from magento/graphql-ce:975-test-coverage-CartAddressTypeResolver
 - Merged commits:
   1. 493d744
sidolov pushed a commit that referenced this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants