Skip to content

MAGECLOUD-4980: Pagebuilder patches fail CE functional tests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 8, 2020
Merged

MAGECLOUD-4980: Pagebuilder patches fail CE functional tests #14

merged 4 commits into from
Jan 8, 2020

Conversation

@billygilbert
Copy link

@billygilbert billygilbert commented Jan 8, 2020

Description

Pagebuilder patches fail on CE functional tests due to PB module not being present

Fixed Issues (if relevant)

  1. MAGECLOUD-4980

Manual testing scenarios

  1. Confirm any PB patches still apply.
  2. Review automated functional tests for CE after merge.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@shiftedreality shiftedreality changed the base branch from develop to 1.0 January 8, 2020 19:00
@shiftedreality shiftedreality added the Progress: review PR/issue status label Jan 8, 2020
@billygilbert billygilbert added qa and removed Progress: review PR/issue status labels Jan 8, 2020
@andriyShevtsov
Copy link
Collaborator

andriyShevtsov commented Jan 8, 2020

QA approved

@andriyShevtsov andriyShevtsov removed the qa label Jan 8, 2020
@shiftedreality shiftedreality added the Progress: approved PR/issue status label Jan 8, 2020
@shiftedreality shiftedreality merged commit 9524c87 into 1.0 Jan 8, 2020
@shiftedreality shiftedreality deleted the MAGECLOUD-4980 branch January 8, 2020 20:30
mmansoor-magento pushed a commit that referenced this pull request Jan 21, 2021
@bbatsche
Add @group to PatchApplierCest (#14)
b31f562
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@shiftedreality
MAGECLOUD-4980: Pagebuilder patches fail CE functional tests (#14)
aed7043
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@bbatsche
Add @group to PatchApplierCest (#14)
af3d746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@bbatsche bbatsche bbatsche approved these changes

@shiftedreality shiftedreality shiftedreality approved these changes

@michaelcasey316 michaelcasey316 michaelcasey316 approved these changes

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Progress: approved PR/issue status Release Line: 1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@billygilbert @andriyShevtsov @bbatsche @shiftedreality @michaelcasey316 @oshmyheliuk