Skip to content

Conversation

@BaDos
Copy link
Contributor

@BaDos BaDos commented Jan 17, 2020

Description

Fixed Issues (if relevant)

https://magento2.atlassian.net/browse/MAGECLOUD-4530

Manual testing scenarios

https://jira.corp.magento.com/browse/MC-6465

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

patches.json Outdated
">=2.2.10 <2.3.0": "MAGECLOUD-4530__fix_cron_deadlocks_and_improve_job_locking__2.2.10.patch",
"2.3.0": "MAGECLOUD-4530__fix_cron_deadlocks_and_improve_job_locking__2.3.0.patch",
"2.3.1": "MAGECLOUD-4530__fix_cron_deadlocks_and_improve_job_locking__2.3.1.patch",
"2.3.2": "MAGECLOUD-4530__fix_cron_deadlocks_and_improve_job_locking__2.3.2.patch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3.2 has patch version if this patch should be applied to the patch version you need to change constraints

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshmyheliuk thanks, fixed.

@BaDos
Copy link
Contributor Author

BaDos commented Jan 23, 2020

The PR to Magento core was merged: https://github.com/magento/magento2ce/pull/5225

@BaDos BaDos requested a review from oshmyheliuk January 23, 2020 17:23
shiftedreality
shiftedreality previously approved these changes Jan 23, 2020
oshmyheliuk
oshmyheliuk previously approved these changes Jan 23, 2020
@oshmyheliuk oshmyheliuk added qa and removed Progress: review PR/issue status labels Jan 23, 2020
@NadiyaS NadiyaS dismissed stale reviews from oshmyheliuk and shiftedreality January 23, 2020 18:41

The base branch was changed.

@NadiyaS NadiyaS changed the base branch from develop to 1.0 January 23, 2020 18:41
@NadiyaS
Copy link
Contributor

NadiyaS commented Jan 24, 2020

QA approved for 2.3.0 and 2.3.3 Magento versions

@shiftedreality shiftedreality merged commit 5b5594d into 1.0 Jan 24, 2020
@shiftedreality shiftedreality deleted the MAGECLOUD-4530 branch January 24, 2020 17:44
@shiftedreality shiftedreality added Progress: approved PR/issue status and removed qa labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Progress: approved PR/issue status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants