Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-5069: FPC is getting disabled during deployments #27

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

dyushkin
Copy link
Contributor

@dyushkin dyushkin commented Feb 20, 2020

MAGECLOUD-5069: FPC is getting disabled during deployments

Description

The patch fixes disabling of FPC in env.php when bin/magento maintenance:enable performed.

Fixed Issues (if relevant)

  1. https://magento2.atlassian.net/browse/MAGECLOUD-5069

Manual testing scenarios

  1. Performing bin/magento maintenance:enable CLI command.
  2. full_page flag in app/etc/env.php isn't becoming 0 (previously it was)
  3. Performing bin/magento maintenance:disable CLI command.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

releasenote
Added the "FPC is getting disabled during deployments" patch for Magento 2.3.2 and later releases to fix an issue that disabled the full page cache during the Magento deployment process.

@dyushkin dyushkin requested a review from BaDos February 20, 2020 18:44
@BaDos BaDos added the Release: 1.0.3 MCP Release label Feb 20, 2020
@BaDos BaDos added the Progress: review PR/issue status label Feb 20, 2020
@BaDos BaDos requested a review from oshmyheliuk February 20, 2020 19:19
@@ -241,6 +241,9 @@
},
"Fix PayPal issue with region": {
"2.3.4": "MC-31387__fix_paypal_issue_with_region__2.3.4.patch"
},
"FPC is getting disabled during deployments": {
">=2.3.2 <2.4.0": "MAGECLOUD-5069__fpc_is_getting_disabled_during_deployments__2.3.2.patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix won't be delivered into 2.3.x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there are no plans to deliver it to 2.3 as far as I know.

@BaDos BaDos added qa and removed Progress: review PR/issue status labels Feb 20, 2020
@andriyShevtsov andriyShevtsov self-assigned this Feb 20, 2020
@andriyShevtsov
Copy link
Contributor

QA approved

@andriyShevtsov andriyShevtsov added Progress: approved PR/issue status and removed qa labels Feb 24, 2020
@oshmyheliuk oshmyheliuk merged commit 4a385e2 into magento:develop Feb 25, 2020
@YPyltiai YPyltiai added Release: 1.0.2 MCP Release and removed Release: 1.0.3 MCP Release labels Mar 4, 2020
magento-cicd2 pushed a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants