Skip to content

MCLOUD-5771: Redis out of memory on integration environments #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dhorytskyi
Copy link
Contributor

Description

Magento fails with the following errors if Redis has used all allocated memory:

report.CRITICAL: OOM command not allowed when used memory > 'maxmemory'. {"exception":"[object] (CredisException(code: 0): OOM command not allowed when used memory > 'maxmemory'. at /app/vendor/colinmollenhour/credis/Client.php:1197, CredisException(code: 0): OOM command not allowed when used memory > 'maxmemory'. at /app/vendor/colinmollenhour/credis/Client.php:1157, RedisException(code: 0): OOM command not allowed when used memory > 'maxmemory'. at /app/vendor/colinmollenhour/credis/Client.php:1119)"} []

Since eviction mechanism in Redis doesn't guarantee 100% eviction rate we need to cover this case.

Fixed Issues (if relevant)

https://jira.corp.magento.com/browse/MCLOUD-5771

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

shiftedreality
shiftedreality previously approved these changes May 7, 2020
bbatsche
bbatsche previously approved these changes May 7, 2020
@dhorytskyi dhorytskyi dismissed stale reviews from bbatsche and shiftedreality via cf54709 May 7, 2020 17:49
@kandy
Copy link

kandy commented May 12, 2020

Please pay attention that this patches is not possible (or hard) to use without his changes magento/ece-tools#724
Also #46 have patches for the same files

"Failure tolerance Redis cache backend": {
">=2.3.0 <2.3.5": "MCLOUD-5771__failure_tolerance_redis_cache_backend__2.3.0.patch",
">=2.3.5 <2.3.6": "MCLOUD-5771__failure_tolerance_redis_cache_backend__2.3.5.patch",
">=2.3.0 <2.4.0": "MCLOUD-5771__change_redis_cache_adapter__2.3.x.patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename MCLOUD-5771__change_redis_cache_adapter__2.3.x.patch to MCLOUD-5771__change_redis_cache_adapter__2.3.0.patch

@dhorytskyi
Copy link
Contributor Author

Those changes will be delivered in scope of #46

@dhorytskyi dhorytskyi closed this May 13, 2020
@dhorytskyi dhorytskyi deleted the MCLOUD-5771 branch May 13, 2020 21:50
@hostep
Copy link

hostep commented Sep 25, 2020

Just FYI, but the contents of patches/MCLOUD-5771__failure_tolerance_redis_cache_backend__2.3.5.patch wasn't included in #46 as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants