Skip to content

Conversation

@NadiyaS
Copy link
Contributor

@NadiyaS NadiyaS commented Nov 23, 2019

Description

Check all patches from https://magento.com/tech-resources/download for 2.1.4+ versions and bundle missing patches to magento-cloud-patches

Manual testing scenarios

check edge versions to which patches should be applied
e.g. if patch should be applied for >=2.1.4 <2.2.0, need to check 2.1.4 version and on the latest 2.1 version - 2.1.18.
There is one custom patch - PRODSECBUG-2233 for 2.2.0-2.2.6 versions. It includes fix for PRODSECBUG-2233 and part of fix from https://jira.corp.magento.com/browse/MAGETWO-95236. So, we need to test functionality it fixes on one of 2.2.0-2.2.6 version. Description of it can be taken from https://jira.corp.magento.com/browse/PRODSECBUG-2233

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@NadiyaS NadiyaS added the onhold label Nov 24, 2019
@NadiyaS NadiyaS removed the onhold label Dec 3, 2019
@mveeramneni mveeramneni added the Progress: review PR/issue status label Dec 3, 2019
oshmyheliuk
oshmyheliuk previously approved these changes Dec 3, 2019
@arhiopterecs arhiopterecs added qa and removed Progress: review PR/issue status labels Dec 5, 2019
@andriyShevtsov
Copy link
Collaborator

Waiting for environment fix. Ticket in zendesk 264557

@andriyShevtsov
Copy link
Collaborator

QA approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Progress: approved PR/issue status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants