Make MC-43048 available for 2.4.3-p1 #84

arnoudhgz · 2021-11-10T11:33:33Z

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

Manual testing scenarios

Locally install Magento Cloud version 2.4.3-p1
See if the patch is listed with vendor/bin/ece-patches status
Add the patch in .magento.env.yaml
Apply the patch with vendor/bin/ece-patches apply

Contribution checklist

Pull request has a meaningful description of its purpose
Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

magento-cloud-ft-jenkins-svc · 2021-11-10T11:40:01Z

Unit Test Results

✅ All unit tests have passed.

Unit Test Output

> phpunit --configuration tests/unit '--log-junit' 'tests/unit/tmp/junit.xml' '--coverage-clover' 'tests/unit/tmp/clover.xml'
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

...............................................................  63 / 161 ( 39%)
............................................................... 126 / 161 ( 78%)
...................................                             161 / 161 (100%)

Time: 1.88 seconds, Memory: 18.00 MB

OK (161 tests, 397 assertions)

Generating code coverage report in Clover XML format ... done

This comment was generated by Jenkins job magento-cloud-patches/unit build 47.

magento-cloud-ft-jenkins-svc · 2021-11-10T11:40:07Z

Static Analysis & Code Style Results

✅ All static analysis and code style checks have passed.

PHP Codesniffer Output

> phpcs src --standard=tests/static/phpcs-ruleset.xml -p -n
............................................................  60 / 154 (39%)
............................................................ 120 / 154 (78%)
..................................                           154 / 154 (100%)


Time: 5.23 secs; Memory: 12MB

PHP Mess Detector Output


Found 0 violations and 0 errors in 3317ms

�[32mNo mess detected�[0m

This comment was generated by Jenkins job magento-cloud-patches/static build 48.

magento-cloud-ft-jenkins-svc · 2021-11-10T14:07:12Z

Functional Acceptance Test Results

❌ One or more functional acceptance tests have failed.

PHP 7.2

✅ Acceptance72Cest
✅ Acceptance72CeCest

PHP 7.3

✅ Acceptance73CeCest
✅ Acceptance73Cest

PHP 7.4

✅ PatchApplierCest
❌ AcceptanceCeCest
✅ AcceptanceCest

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 83.

magento-cloud-ft-jenkins-svc · 2021-11-10T14:07:13Z

PHP 7.4 AcceptanceCeCest Output

Codeception PHP Testing Framework v2.5.6
Powered by PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
Running with seed: 


Acceptance Tests (10) --------------------------------------
AcceptanceCeCest: Test patches | "2.4.0","2.4.0"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.0"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.0","2.4.0-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.0-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.1","2.4.1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.1","2.4.1-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.1-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.2-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.2","2.4.2-p2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.2-p2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

AcceptanceCeCest: Test patches | "2.4.3","2.4.3"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.3"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.4.3"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
AcceptanceCeCest: Test patches | "2.4.3","2.4.3-p1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.4.3"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.4.3-p1"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
AcceptanceCeCest: Test patches | "master"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest:testPatches
Test: src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "master"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I get work dir path 
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/p...",">=2.4.3 <..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(60): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2307): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1156): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/codeception/src/Codeception/Util/Shared/Asserts.php(267): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 /app/vendor/codeception/codeception/src/Codeception/Module/Asserts.php(263): Codeception\Module->assertTrue(false, '')
#5 [internal function]: Codeception\Module\Asserts->assertTrue(false)
#6 /app/vendor/codeception/codeception/src/Codeception/Step.php(265): call_user_func_array(Array, Array)
#7 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(72): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#8 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(3534): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#9 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(39): CliTester->assertTrue(false)
#10 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#11 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(127): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCeCest), 'testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#15 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(89): Codeception\Test\Cest->test()
#16 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(746): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(118): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(158): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(192): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#20 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(159): Codeception\Codecept->runSuite(Array, 'Acceptance', 'AcceptanceCeCes...')
#21 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(384): Codeception\Codecept->run('Acceptance', 'AcceptanceCeCes...', Array)
#22 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/src/Codeception/Application.php(108): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#27 /app/vendor/codeception/codeception/codecept(43): Codeception\Application->run()
#28 {main}
------------------------------------
------------------------------------------------------------
713x DEPRECATION: Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as the first argument is deprecated since Symfony 4.3, pass it as the second argument and provide the event object as the first argument instead. /app/vendor/symfony/event-dispatcher/EventDispatcher.php:58
207x DEPRECATION: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell. /app/vendor/symfony/process/Process.php:147
110x DEPRECATION: The Robo\Common\ProcessUtils::escapeArgument() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0. /app/vendor/consolidation/robo/src/Common/ProcessUtils.php:39
14x DEPRECATION: The "Symfony\Component\BrowserKit\Response::getStatus()" method is deprecated since Symfony 4.3, use getStatusCode() instead. /app/vendor/symfony/browser-kit/Response.php:100
3x DEPRECATION: Calling the "Codeception\Lib\Connector\Guzzle6::getInternalResponse()" method before the "request()" one is deprecated since Symfony 4.1 and will throw an exception in 5.0. /app/vendor/symfony/browser-kit/Client.php:217


Time: 1.92 hours, Memory: 26.00 MB

There were 3 failures:

---------
1) AcceptanceCeCest: Test patches | "2.4.3","2.4.3"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 32. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 31. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 30. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 28. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 27. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


---------
2) AcceptanceCeCest: Test patches | "2.4.3","2.4.3-p1"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 32. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 31. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 30. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 28. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 27. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


---------
3) AcceptanceCeCest: Test patches | "master"
 Test  src/Test/Functional/Acceptance/AcceptanceCeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 33. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:101
 32. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:100
 31. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 30. $I->runDockerComposeCommand("run deploy cloud-deploy") at src/Test/Functional/Acceptance/AcceptanceCest.php:39
 29. $I->assertTrue(true) at src/Test/Functional/Acceptance/AcceptanceCest.php:38
 28. $I->startEnvironment() at src/Test/Functional/Acceptance/AcceptanceCest.php:38


FAILURES!
Tests: 10, Assertions: 51, Failures: 3.
- XML report generated in file:///app/tests/functional/_output/junit.xml

This comment was generated by Jenkins job magento-cloud-patches/functional build 83.

MCLOUD-11143: Return MCLOUD-10604 patch back with updated constraints

Make MC-43048 available for 2.4.3-p1

b144959

The rate limit patch is still needed in the latest Magento version 2.4.3-p1, but was not listed anymore for that version.

m2-community-project bot added the Progress: ready for review label Nov 10, 2021

michaelcasey316 assigned BaDos Jun 22, 2022

m2-community-project bot added Progress: review PR/issue status and removed Progress: ready for review labels Jun 22, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 11, 2023

Merge pull request #84 from magento-commerce/MCLOUD-11143

712bb26

MCLOUD-11143: Return MCLOUD-10604 patch back with updated constraints

BaDos removed their assignment Mar 2, 2024

m2-community-project bot added Progress: ready for review and removed Progress: review PR/issue status labels Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make MC-43048 available for 2.4.3-p1 #84

Make MC-43048 available for 2.4.3-p1 #84

arnoudhgz commented Nov 10, 2021

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Make MC-43048 available for 2.4.3-p1 #84

Are you sure you want to change the base?

Make MC-43048 available for 2.4.3-p1 #84

Conversation

arnoudhgz commented Nov 10, 2021

Manual testing scenarios

Contribution checklist

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Unit Test Results

Unit Test Output

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Static Analysis & Code Style Results

PHP Codesniffer Output

PHP Mess Detector Output

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

Functional Acceptance Test Results

PHP 7.2

PHP 7.3

PHP 7.4

magento-cloud-ft-jenkins-svc commented Nov 10, 2021

PHP 7.4 AcceptanceCeCest Output