PSR-12 update

[ghost]

Now that PSR12 has been released accepted, when will we see an update to include it as part of the ruleset?
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Standards/PSR12/ruleset.xml

ToDo list:

• Open PR to the magento/magento-coding-standard with ruleset.xml update.

[lenaorobei]

Hi @paul-gene! That's a really good question. If you are interested in promoting this idea it would be great if you could open a proposal in the magento/architecture repo.

[lenaorobei]

@paul-gene if you dont mind, I will update this issue with the action items that need to be done in order to accomplish this task.

[coderimus]

Hello @lenaorobei just a status update:

1. I updated my local phpcs to the latest stable version PHP_CodeSniffer version 3.5.3 (stable) and made a diff between PSR-2 and PSR-12 as we discussed. I am with the Generic list. Everything is clear at this moment.

2. During the investigation I wound next: Magento uses this package friendsofphp/php-cs-fixer to provide an auto-fix functionality. Currently, this package has an open PR (Initial PSR12 ruleset creation PHP-CS-Fixer/PHP-CS-Fixer#4695) for the PSR-12 upgrade and also tag with the PHP 7.4 support. Think that we will need to upgrade it's version also.

[lenaorobei]

Hi @coderimus! Thanks for the update.

1. Perfect. Let me know if you need any help with this.
2. friendsofphp/php-cs-fixer is a different from phpcs tool and is not actually related to this repo. I think that such changes should be done in https://github.com/magento/magento2 repo. By the way, sniffer also has OOB beautifier tool phpcbf.

[lenaorobei]

Hi @coderimus. I've unassigned you from this issue, since no updates were provided.
Hopefully, somebody will pick this up.
Thanks.