[New Rule] No imports from static tests namespaces #142
Labels
accepted
New rule is accepted
Comments
|
As per magento/architecture#290 it was decided to prohibit any |
lenaorobei
added
accepted
m2-community-project
bot
added
Progress: dev in progress
and removed
Progress: ready for dev
labels
|
Hello @lenaorobei , |
|
@konarshankar, severity - 8, type - warning. |
m2-community-project
bot
added
Progress: PR created
and removed
Progress: dev in progress
labels
lenaorobei
added a commit
to konarshankar07/magento-coding-standard
that referenced
this issue
Dec 11, 2019
lenaorobei
added a commit
that referenced
this issue
Dec 11, 2019
#142 : [New Rule] No imports from static tests namespaces
magento-devops-reposync-svc
pushed a commit
that referenced
this issue
Dec 22, 2021
Run tests on php 8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rule
I suggest to add one rule that will check that there is no imports from static tests namespaces.
Reason
Time to time we're getting issue with running tests on PRs in magento/magento2 repository because someone imported
\Magento\Tests\NamingConvention\true\stringby mistake. As result - we have "No build reports available" for "Database Compare build", "Functional Tests build", "Sample Data Tests build" while Static tests are shown as "failing" but in results - we don't really have reason. Example: https://github.com/magento/magento2/runs/214712913Implementation
Check that all files in all modules do not contains any imports from
\Magento\Tests\NamingConventionnamespaceThe text was updated successfully, but these errors were encountered: