Discourage local-FS-only methods #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidolov
requested changes
Nov 19, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sidolov the pull request successfully imported. |
|
@shiftedreality could you put some docs why it was discouraged? I think the message that it's just discourages isn't clear at all. |
|
@ihor-sviziev do you have any example of how it should be documented? Is there any section in DevDocs? |
|
@ihor-sviziev thanks, added |
ihor-sviziev
previously approved these changes
Nov 30, 2020
ihor-sviziev
approved these changes
Dec 3, 2020
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
getimagesize()to discouraged functions as it does not work with remote storage implementations.Task: https://jira.corp.magento.com/browse/MC-38508