-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements to include php7.3 support #287
Conversation
xdebug support for php 7.3 is in beta and not included in the travis image for php 7.3.
Hi @pmclain Thank you !!!! Update: !!!! |
Hi @okolesnyk sorry for the delay, I must have missed the notification. Thanks for cherry-picking. Please let me know if anything else is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmclain I left two comments on this PR. MFTF compatibility with 7.3 looks good, and this update looks mostly good in terms of dependency compatibility with Magento.
@@ -15,7 +15,9 @@ vendor/bin/phpunit --configuration dev/tests/phpunit.xml --testsuite unit --cove | |||
echo "===============================" | |||
echo " UNIT TEST COVERAGE" | |||
echo "===============================" | |||
vendor/bin/coverage-check clover.xml $UNIT_COVERAGE_THRESHOLD | |||
if [[ ${TRAVIS_PHP_VERSION:0:3} != "7.3" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmclain I know it's been some time since this PR was created, but Xdebug 2.7.0 has since been released (with 7.3 support).
At this point, is this conditional skip still necessary?
@@ -4,7 +4,7 @@ | |||
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", | |||
"This file is @generated automatically" | |||
], | |||
"content-hash": "ab52f12570440f5833f0d81bce06f884", | |||
"content-hash": "0a58509a75dc4ea99a4bef3d13ee4075", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A heads up, composer.json
and .lock
has changed since this was originally created, the merge is pretty ugly.
You may be better off taking your current lock file and running a simple composer update allure-framework/allure-codeception
after resolving composer.json
conflicts.
Update MFTF to solve the issue with php-webdriver
Description
Add support for php 7.3
brainmaestro/composer-git-hooks
tov2.6.1
Contribution checklist