executeInSelenium action does not generate proper code #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeInSelenium action does not generate proper code because this action was not included in
ActionObject::FUNCTION_CLOSURE_ACTIONS
Steps to reproduce
<executeInSelenium function="function ($webdriver) { return 'Hello, World!'}" stepKey="testStep"/>
vendor/bin/mftf generate:tests
Expected result
There is generated action
$I->executeInSelenium(function ($webdriver) { return 'Hello, World!'});
Function is passed as Closure.
Actual result
There is generated action
$I->executeInSelenium("function ($webdriver) { return 'Hello, World!'}");
Function is passed as string not Closure. So if you run test you will get exception here.
Contribution checklist