Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'CURLOPT_SSL_VERIFYHOST' to the default curl options so that se… #39

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Conversation

Cristian101
Copy link
Contributor

@Cristian101 Cristian101 commented Feb 16, 2018

…lf signed certificates can work, for development purposes

Description

For development purposes it's useful to allow the framework to test domains that use a self signed certificate. The API used for actions such as "createData" doesn't properly give curl the configuration to skip the SSL verification. From the looks of it, it's supposed to skip it, because it sets the 'CURLOPT_SSL_VERIFYPEER' to 'false', but for that to work, it also needs to set 'CURLOPT_SSL_VERIFYHOST' to 'false', which is what I did.

Fixed Issues (if relevant)

  1. Unable to make API requests using self signed certificate to HTTPS domain #37: Unable to make API requests using self signed certificate to HTTPS domain

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…lf signed certificates can work, for development purposes
@magento-cicd2
Copy link

magento-cicd2 commented Feb 16, 2018

CLA assistant check
All committers have signed the CLA.

@okolesnyk
Copy link
Member

Hi @Cristian101
Thank you for your contribution. Internal task created to process your Issue and Pull Request.
MQE-804

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work for execution, but attempting to generate tests against a server that uses a self signed certificate causes the same issue.

Need to add the following code to ModuleResolver.php lines 149 and 279:
curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false); curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);

@Cristian101
Copy link
Contributor Author

I made the changes requested by @KevinBKozan

@KevinBKozan
Copy link
Contributor

CR/QA Complete. Verified all of this works against a local Magento installation that uses self-signed certificate.

@KevinBKozan KevinBKozan merged commit d0ec272 into magento:develop Feb 26, 2018
magento-cicd2 pushed a commit that referenced this pull request Mar 30, 2021
MQE-2495: config parallel by group count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants