Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE-1055: [SPIKE] Audit performance issues with test generation in framework #431

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

tomreece
Copy link
Contributor

During my spike I identified these two quick fixes to increase test performance.

@coveralls
Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage increased (+0.02%) to 52.201% when pulling c9120e0 on MQE-1055 into ee12a62 on develop.

@tomreece tomreece requested a review from KevinBKozan August 26, 2019 15:44
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good, can confirm we gained a substancial performance increase, just had a comment about memory.

@tomreece tomreece merged commit 3c7ed4b into develop Aug 27, 2019
@tomreece tomreece deleted the MQE-1055 branch September 3, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants