-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to include multiple non primitive types in an array #433
Conversation
If an array is defined for an entity it is currently not possible to include different types of non primitive types in the same array.
Hey @ochnygosch, thank you for your submission! We created a ticket internally for reviewing your PR, and will be updating you with feedback and progress on this PR. |
Hi @ochnygosch! This change looks good to me after some manual testing. |
Hi @ochnygosch, thank you very much for adding unit tests to your change. We have one last thing to resolve, Do you see this error in the Travis results? Can you fix this Cyclomatic Complexity error without simply suppressing it? Give it a shot and if you can't resolve it then we will discuss whether to allow a suppression of it or not. Thank you for your time and contribution to MFTF. |
Hi @ochnygosch -- Just checking in, You don't have to fix the cyclomatic complexity warning. I will do this for you. But we do need you to sign the Adobe CLA. Thanks! |
@KevinBKozan After code freeze, merge PR #490 |
MQE-1749: Review Community PR #433
Description
If an array is defined for an entity it is currently not possible to
include different types of non primitive types in the same array.
E.g. it is not possible to add a product, whose "custom_attributes" field
should contain attributes that have a primitive type (e.g. url_key) and an
array type (e.g. category_ids)
This PR adds the ability to define multiple non primitive types for an array
type.
The definition of the CreateProduct request in
magento-catalog/Test/Mftf/Metadata/product-meta.xml could be changed to
Contribution checklist