Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of TestGenerator class #537

Merged
merged 5 commits into from
Jan 7, 2020
Merged

Refactor of TestGenerator class #537

merged 5 commits into from
Jan 7, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description

Set of changes to improve readability and performance of TestGenerator.

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Strix labels Jan 6, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 53.312% when pulling 47fd2e6 on lbajsarowicz:refactor/mftf-test-generator into 9bc59f8 on magento:develop.

@coveralls
Copy link

coveralls commented Jan 6, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 52.741% when pulling 771716d on lbajsarowicz:refactor/mftf-test-generator into 052576d on magento:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 53.312% when pulling 47fd2e6 on lbajsarowicz:refactor/mftf-test-generator into 9bc59f8 on magento:develop.

@soumyau soumyau self-requested a review January 7, 2020 16:44
soumyau
soumyau suggested changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor documentation comment added. Running an internal build to verify changes are not breaking anything.

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php
return $output;
}

// @codingStandardsIgnoreEnd

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to add a description of what the function does in header (applies to all new functions added)

@lbajsarowicz
Copy link
Contributor Author

These coding standards are ridiculous
image

@soumyau soumyau added the accept label Jan 7, 2020
@soumyau soumyau merged commit 231e58d into magento:develop Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
accept Partner: Strix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbajsarowicz @coveralls @soumyau @magento-engcom-team