Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#544 Log Request sent even if Response failed #567

Merged
merged 2 commits into from
Apr 17, 2020
Merged

#544 Log Request sent even if Response failed #567

merged 2 commits into from
Apr 17, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description

I'm not feeling comfortable yet to rewrite the Request classes, however that would be really useful to have possibility of reviewing what was actually sent to Web API.

According to that fact - I moved saving request before calling the API. As a result - even if API request fails, you still have the request contents.

Fixed Issues (if relevant)

  1. MFTF: Lack of information on API failure (eg. <createEntity>) #544

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2020
@coveralls
Copy link

coveralls commented Jan 31, 2020

Coverage Status

Coverage remained the same at 52.787% when pulling 8d6c5d5 on lbajsarowicz:bugfix/544-missing-request-information into 5ac5683 on magento:MFTF3.0.0-RC2.

KevinBKozan
KevinBKozan previously approved these changes Apr 17, 2020
@okolesnyk okolesnyk changed the base branch from develop to MFTF3.0.0-RC2 April 17, 2020 18:17
@okolesnyk okolesnyk dismissed KevinBKozan’s stale review April 17, 2020 18:17

The base branch was changed.

@okolesnyk okolesnyk requested a review from KevinBKozan April 17, 2020 18:20
@okolesnyk okolesnyk merged commit 4f1dd85 into magento:MFTF3.0.0-RC2 Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Mediotype partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants