Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2-functional-testing-framework#58: Allow browser type … #67

Merged
merged 3 commits into from
Mar 29, 2018

Conversation

StasKozar
Copy link
Contributor

Fixed issue #58

@magento-cicd2
Copy link

magento-cicd2 commented Mar 24, 2018

CLA assistant check
All committers have signed the CLA.

.env.example Outdated
@@ -19,6 +19,9 @@ MAGENTO_ADMIN_PASSWORD=
#SELENIUM_PROTOCOL=http
#SELENIUM_PATH=/wd/hub

#*** Browser for running tests, default chrome. Uncomment and change if you want to run tests on another browser (ex. firefox).
#BROWSER=chrome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment BROWSER
Let it be always set by default to chrome

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@coveralls
Copy link

coveralls commented Mar 25, 2018

Coverage Status

Coverage remained the same at 53.382% when pulling 44ced3f on StasKozar:MFTF-58 into 08c089a on magento:CD-develop.

@okolesnyk okolesnyk merged commit e01f07e into magento:CD-develop Mar 29, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 21, 2021
…2-functional-testing-framework-854

[Imported] CE-32868: Updated "monolog" to the latest version 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants