-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outlining the difference between Allure severity levels #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobooth
previously approved these changes
Jul 13, 2020
okolesnyk
previously approved these changes
Jul 13, 2020
okolesnyk
force-pushed
the
AM/severity-levels
branch
from
July 24, 2020 15:09
194cf0b
to
f958045
Compare
tomreece
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by @dobooth also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to clarify the difference between the different levels of Severity (
MINOR
,AVERAGE
,MAJOR
,CRITICAL
orBLOCKER
), as per Magento's customised use of this Allure annotation.Description
When writing MFTF tests, it's often difficult to know what severity level to apply. Currently, the docs don't explain this.
I've learned that Magento has its own custom set of levels that are mapped to Allure's level names. I haven't linked to Allure's site or provided a table indicating the matching of Magento names to Allure names, because I don't think this is very helpful. I've just edited Alex Kolesnyk's explanation to me of the levels vis a vis their impact on conversion rate.
Broken links to devhub.io are replaced with github.com paths.
Affected pages
Contribution checklist