[Pangolin] Requested bug fixes #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed resolveTestVariable to process each arg individually, as opposed to the whole string. - fixed quote breaking issue. - Added verification cest for persisted data replacement.
- changed if statement to is_null instead of empty, empty("0") = true
…ng selector1 and selector2 attributes - Added addUniquenessFunctionCall to selector1/2 attributes.
…data
- fixed regexPattern for variables to include [] for cases like {{arg.street[0]}}
- added check for $variableName = null
- fixed camel casing issue with array key
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 3, 2020
Fixing link that will break soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
Checklist