Update allure-codeception in order to support php8 #825
Conversation
| @@ -15,7 +15,7 @@ | |||
| "ext-intl": "*", | |||
| "ext-json": "*", | |||
| "ext-openssl": "*", | |||
| "allure-framework/allure-codeception": "~1.4.0", | |||
| "allure-framework/allure-codeception": "~1.5.0", | |||
There was a problem hiding this comment.
Also for backward compatibility we might keep something like this:
| "allure-framework/allure-codeception": "~1.5.0", | |
| "allure-framework/allure-codeception": "~1.4.0||~1.5.0", |
but I'm not sure how much we need it, as there for sure some diffs between these version and it will be much harder to support both versions at once
|
Looks like unit test failures not related to changes from this PR. |
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
|
@ihor-sviziev since our build infrastructure is not currently support php8 and other php8 work is still WIP, we have created a new branch php8-develop and this PR is merged into that branch. Please let us know if this works for you. |
|
@jilu1 but somehow it's still not showing merged. Should I change target to that branch ? |
|
@ihor-sviziev I think you are right. I just reverted your commit from php8-develop, after it's sync with public repo (you might want to wait a bit), you can change PR to base from php8-develop. |
|
@ihor-sviziev you can fix the base of this PR now. |
|
@jilu1 changed target to php8-develop |
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
Description
This PR updates
allure-codeceptionto version 1.5 in order to bring compatibility with PHP8. It is needed in order to resolve dependencies issue for magento/magento2#32614Fixed Issues (if relevant)
Contribution checklist