Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure multiple OTPs #830

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

fooman
Copy link
Contributor

@fooman fooman commented May 9, 2021

Description

Improve Extendability of OTP implementation.

The current implementation of the OTP works well for use with Magento's admin. It can even be used for other use cases. What is not possible in its current form is accessing multiple OTPs within the same test run. This is for example needed when trying to configure a Magento admin setting based on a value provided by a 3rd party also behind a 2FA.

Even changing the shared secret on the fly with something like <magentoCLI command="security:tfa:google:set-secret admin {{_CREDS.fooman/other/OTP_SHARED_SECRET}}" stepKey="setSecret"/>
does not work as the OTP is only initialised once.

This PR allows providing a separate secret
<getOTP stepKey="getOtherOtp" userInput="fooman/other/OTP_SHARED_SECRET"/>
with
<getOTP stepKey="getOtp" />
retaining the default implementation for Magento's Admin 2FA.

Fixed Issues (if relevant)

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@fooman fooman marked this pull request as ready for review May 9, 2021 23:07
@jilu1
Copy link
Contributor

jilu1 commented May 17, 2021

@fooman
Thank you for your pull request! And i see the value/use case to extend this feature.

I will import this PR and we will review and process it according to standard priority. Let us know if this is a blocker or you need it urgently.

@jilu1
Copy link
Contributor

jilu1 commented May 17, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@jilu1
Copy link
Contributor

jilu1 commented May 17, 2021

https://jira.corp.magento.com/browse/MQE-2683 is created to for this issue and we will update with progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants