Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33300: Eliminated AspectMock usage from SuiteObjectHandlerTest.php #845

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Jul 4, 2021

Description

I've eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/Suite/Handlers/SuiteObjectHandlerTest.php

Fixed Issues (if relevant)

  1. Fixes [MFTF] Eliminate AspectMock from SuiteObjectHandlerTest (Complex!) magento2#33300: [MFTF] Eliminate AspectMock from SuiteObjectHandlerTest (Complex!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

Copy link

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @anzin
Thank you for your contribution.
Changes look well for me.

@andrewbess andrewbess requested a review from jilu1 July 20, 2021 16:07
@bohdan-harniuk bohdan-harniuk added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 21, 2021
@andrewbess andrewbess self-assigned this Jul 22, 2021
@bohdan-harniuk bohdan-harniuk self-requested a review July 23, 2021 13:05
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan

@jilu1
Copy link
Contributor

jilu1 commented Aug 3, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit dc2aa4f into magento:develop Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MFTF] Eliminate AspectMock from SuiteObjectHandlerTest (Complex!)
6 participants