Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFTF-33302: Eliminated AspectMock from ActionGroupObjectTest #846

Merged
merged 1 commit into from
Jul 26, 2021
Merged

MFTF-33302: Eliminated AspectMock from ActionGroupObjectTest #846

merged 1 commit into from
Jul 26, 2021

Conversation

bohdan-harniuk
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk commented Jul 4, 2021

Description

Eliminated AspectMock usage from the \tests\unit\Magento\FunctionalTestFramework\Test\Objects\ActionGroupObjectTest

Fixed Issues (if relevant)

  1. [MFTF] Eliminate AspectMock from ActionGroupObjectTest (Complex!) magento2#33302: Eliminate AspectMock from ActionGroupObjectTest (Complex!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backwards-incompatible changes for tests or have related Pull Request with fixes to tests

Copy link

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bohdan-harniuk
Thank you for your contribution.
It looks well for me.

@andrewbess andrewbess requested a review from jilu1 July 20, 2021 15:48
@bohdan-harniuk bohdan-harniuk added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 21, 2021
@andrewbess andrewbess self-assigned this Jul 22, 2021
@bohdan-harniuk
Copy link
Contributor Author

Hello, @jilu1

This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.

Thanks, Bohdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants