Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33299: Eliminated AspectMock usage from SuiteGeneratorTest.php #859

Merged
merged 3 commits into from
Aug 6, 2021
Merged

33299: Eliminated AspectMock usage from SuiteGeneratorTest.php #859

merged 3 commits into from
Aug 6, 2021

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Jul 23, 2021

Description

I've eliminated AspectMock usage from dev/tests/unit/Magento/FunctionalTestFramework/Suite/SuiteGeneratorTest.php

Fixed Issues (if relevant)

  1. Fixes [MFTF] Eliminate AspectMock from SuiteGeneratorTest (Complex!) magento2#33299:[MFTF] Eliminate AspectMock from SuiteGeneratorTest (Complex!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 23, 2021
@anzin anzin force-pushed the improvement/mftf-33299-eliminate-aspect-mock-from-suite-generator-test branch 2 times, most recently from 4c58df3 to 3c0dcdd Compare July 23, 2021 12:01
@anzin anzin force-pushed the improvement/mftf-33299-eliminate-aspect-mock-from-suite-generator-test branch from 3c0dcdd to 73416f0 Compare July 23, 2021 12:05
@bohdan-harniuk bohdan-harniuk self-requested a review July 23, 2021 12:17
bohdan-harniuk
bohdan-harniuk previously approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anzin!
Thank you for your contribution!

Hello, @jilu1!
Here was created new service (as a singleton) to mock few private methods of the SuiteGenerator class. I like this implementation. What do you think? Is it a blocker for us or we can proceed with this implementation?

@bohdan-harniuk bohdan-harniuk force-pushed the improvement/mftf-33299-eliminate-aspect-mock-from-suite-generator-test branch from be75512 to 665066c Compare July 23, 2021 12:21
@bohdan-harniuk bohdan-harniuk force-pushed the improvement/mftf-33299-eliminate-aspect-mock-from-suite-generator-test branch from 665066c to 74a0892 Compare July 23, 2021 12:26
@bohdan-harniuk bohdan-harniuk requested a review from jilu1 July 23, 2021 12:27
@jilu1 jilu1 removed the in progress label Jul 23, 2021
@jilu1
Copy link
Contributor

jilu1 commented Jul 23, 2021

Removed in progress label. We use it when someone is actively reviewing a ticket.

andrewbess
andrewbess approved these changes Jul 23, 2021
View reviewed changes
Copy link

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anzin!
Thank you for your contribution!

@andrewbess andrewbess self-assigned this Jul 23, 2021
@bohdan-harniuk bohdan-harniuk mentioned this pull request Jul 26, 2021
Merged
5 tasks
@anzin anzin mentioned this pull request Jul 26, 2021
Merged
5 tasks
@KevinBKozan KevinBKozan self-requested a review July 29, 2021 14:16
bohdan-harniuk
bohdan-harniuk approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @anzin!
Thank you for your work here!

@KevinBKozan
Copy link
Contributor

@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework

@magento-engcom-team
Copy link

@KevinBKozan the pull request successfully imported.

@eduard13 eduard13 self-assigned this Aug 5, 2021
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ceb7e83 into magento:develop Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdan-harniuk bohdan-harniuk bohdan-harniuk approved these changes

@andrewbess andrewbess andrewbess approved these changes

@jilu1 jilu1 Awaiting requested review from jilu1

@KevinBKozan KevinBKozan Awaiting requested review from KevinBKozan

Assignees

@andrewbess andrewbess

@eduard13 eduard13

@bohdan-harniuk bohdan-harniuk

Labels
in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MFTF] Eliminate AspectMock from SuiteGeneratorTest (Complex!)
8 participants
@anzin @jilu1 @KevinBKozan @magento-engcom-team @andrewbess @bohdan-harniuk @eduard13 @magento-devops-reposync-svc