Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE-743: Can't run tests without a store having "default" store code #86

Merged
merged 5 commits into from
Apr 5, 2018
Merged

MQE-743: Can't run tests without a store having "default" store code #86

merged 5 commits into from
Apr 5, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Persistence mechanisms no longer append "default" to requests that do not specify a store code. This allows Magento itself to route the request to the default store.

Fixed Issues (if relevant)

  1. #389 Fix invalid bahaviour of MAGENTO_BACKEND_BASE_URL #743: Can't run tests without a store having "default" store code
  2. Can't run tests without a store having "default" store code #31

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-743: Can't run tests without a store having "default" store code
d7a15d4 
- Persistence mechanisms now do not append 'default' where no store code is given (rely on magento web api to redirect to the default)
- update/delete data actions no longer allow for a storeCode, relies on handler's storeCode for overrides
- create/get data actions take a storeCode, and overwrite the handler's storeCode if given
- TestGenerator updates and fixes to make sure create/delete/update/get work and generate as expected.
@KevinBKozan
Merge branch 'develop' into MQE-743
e3a0d37
@KevinBKozan
MQE-743: Can't run tests without a store having "default" store code
a368082 
- CR Fixes
@KevinBKozan
MQE-743: Can't run tests without a store having "default" store code
ef12078 
- CR Fixes
@KevinBKozan
Merge branch 'develop' into MQE-743
0533654 
- Merge conflicts in TestGenerator deleteData case
@coveralls
Copy link

coveralls commented Apr 5, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 51.343% when pulling 0533654 on MQE-743 into 6eaaa9e on develop.

@KevinBKozan KevinBKozan merged commit 2e466f2 into develop Apr 5, 2018
@KevinBKozan KevinBKozan deleted the MQE-743 branch April 5, 2018 18:45
magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 30, 2021
@KevinBKozan
Merge pull request #86 from magento-commerce/kevin-unit-test-prs
75eb9f7 
Unit Test PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @coveralls