Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark interfaces as API #732

Closed
sivaschenko opened this issue Feb 9, 2021 · 3 comments
Closed

Mark interfaces as API #732

sivaschenko opened this issue Feb 9, 2021 · 3 comments
Assignees
@Usik2203
Labels
Priority: P1 Priority: P1 Progress: done

Comments

@sivaschenko
Copy link
Member

The following interfaces should be marked as API in future-develop branch

  1. magento2-page-builder/app/code/Magento/PageBuilder/Api/Data/TemplateInterface.php
  2. magento2-page-builder/app/code/Magento/PageBuilder/Api/Data/TemplateSearchResultsInterface.php
  3. magento2-page-builder/app/code/Magento/PageBuilder/Api/TemplateRepositoryInterface.php
  4. magento2-page-builder/app/code/Magento/PageBuilder/Model/Catalog/Sorting/OptionInterface.php
  5. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/AttrInterface.php
  6. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/CharacterDataInterface.php
  7. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/CommentInterface.php
  8. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/DocumentFragmentInterface.php
  9. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/DocumentInterface.php
  10. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/DocumentTypeInterface.php
  11. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/ElementInterface.php
  12. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/HtmlCollectionInterface.php
  13. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/HtmlDocumentInterface.php
  14. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/NodeInterface.php
  15. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/NodeListInterface.php
  16. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/PropertyAttributeInterface.php
  17. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/StringMapInterface.php
  18. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/TextInterface.php
  19. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/TokenListInterface.php
  20. magento2-page-builder/app/code/Magento/PageBuilder/Model/Dom/Adapter/XmlDocumentInterface.php
  21. magento2-page-builder/app/code/Magento/PageBuilder/Model/Stage/RendererInterface.php
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko mentioned this issue Feb 9, 2021
Open
@Usik2203
Copy link
Contributor

@magento I am working on this

@gabrieldagama
Copy link
Contributor

These changes should target develop branch.

@Usik2203 Usik2203 mentioned this issue Apr 21, 2021
Merged
magento-cicd2 pushed a commit that referenced this issue Jun 11, 2021
@gabrieldagama
Merge pull request #88 from magento-commerce/imported-magento-magento…
afc7936 
…2-page-builder-740

[Imported] [#732 API Changes] Mark interfaces as API
@engcom-Hotel engcom-Hotel moved this to Done in Backlog Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Usik2203 Usik2203

Labels
Priority: P1 Priority: P1 Progress: done
Projects
Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sivaschenko @gabrieldagama @Usik2203