Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Script #623

Merged
merged 23 commits into from
Sep 28, 2020
Merged

Update Script #623

merged 23 commits into from
Sep 28, 2020

Conversation

bluemwhitew
Copy link
Contributor

@bluemwhitew bluemwhitew commented Aug 27, 2020 •
edited
Loading

Description (*)

Converts existing Page Builder content to conform with the internal styles update.

Fixed Issues

  1. Fixes Developer can style content types output differently per viewport #558 (Sub Task 1)

Manual Testing Scenarios (*)

TBA

Questions or Comments

N/A

Contribution Checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bluemwhitew
#558: Content Types Output Style Attribute Removal
91c59fb 
- Adding `removeAttribute()` Method
@bluemwhitew
#558: Content Types Output Style Attribute Removal
2f5e019 
- Adding Converter to Remove `style` Attribute(s) from Page Builder
@bluemwhitew
#558: Content Types Output Style Attribute Removal
90f7518 
- Adding Integration Test(s)
@omiroshnichenko omiroshnichenko changed the title (WIP) Update Script [WIP] Update Script Aug 27, 2020
@bluemwhitew
#558: Content Types Output Style Attribute Removal
3dffe71 
- Refactoring Using DOMDocument
- Adding `generateDataAttribute` Method
- Adding `generateInternalStyles` Method
- Modifying Ordering of Expected vs. Actual in PageBuilderStripStylesTest
@bluemwhitew
Copy link
Contributor Author

@magento run Static Tests

@omiroshnichenko omiroshnichenko linked an issue Sep 10, 2020 that may be closed by this pull request
Developer can style content types output differently per viewport #558
Closed
7 tasks
@omiroshnichenko omiroshnichenko changed the base branch from 558_content-type-style-attribute-removal to csso-alternative September 10, 2020 16:34
@bluemwhitew
#558: Content Types Output Style Attribute Removal
1e7b674 
- Minor Refactoring
@bluemwhitew
#558: Content Types Output Style Attribute Removal
12fe2e6 
- Amending Integration Tests
- Preparing to Utilise DOMDocument for Testing
@bluemwhitew

This comment has been minimized.

Sign in to view
@bluemwhitew
#558: Content Types Output Style Attribute Removal
30ffcdb 
- Extending Tests
- Refactoring
- Removing `length` from `generateDataAttribute()`
- Suppressing LibXML Errors
@omiroshnichenko
Merge branch 'csso-alternative' of github.com:magento/magento2-page-b…
ac32a27 
…uilder into 558_1_content-type-style-attribute-removal
@omiroshnichenko
#558: Content Types Output Style Attribute Removal
3f1a669 
- use Dom adapter
- replace all style
@omiroshnichenko
Copy link
Contributor

@bluemwhitew Please, take a look at proposed changes .

@bluemwhitew
#558: Content Types Output Style Attribute Removal
368d6fa 
- Code Review Feedback/Amends (Thanks, @barnyshergold/@omiroshnichenko)
@bluemwhitew

This comment has been minimized.

Sign in to view
@bluemwhitew
Merge from 558_1_content-type-style-attribute-removal
60343e5
@bluemwhitew
#558: Content Types Output Style Attribute Removal
043b358 
- Merge from `558_1_content-type-style-attribute-removal-proposed`
- Code Review Feedback/Amends
@bluemwhitew
#558: Content Types Output Style Attribute Removal
f88405d 
- Fixing Integration Tests
@bluemwhitew

This comment has been minimized.

Sign in to view
@bluemwhitew

This comment has been minimized.

Sign in to view
@bluemwhitew

This comment has been minimized.

Sign in to view
@bluemwhitew
Copy link
Contributor Author

@magento run all tests

@bluemwhitew
Copy link
Contributor Author

bluemwhitew commented Sep 28, 2020 •
edited
Loading

Ready for merging. 🤞🏻

/cc @omiroshnichenko

@omiroshnichenko omiroshnichenko merged commit 87984da into csso-alternative Sep 28, 2020
@omiroshnichenko omiroshnichenko deleted the 558_1_content-type-style-attribute-removal branch December 7, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko left review comments

@BarnyShergold BarnyShergold BarnyShergold requested changes

@dhaecker dhaecker Awaiting requested review from dhaecker

Assignees

@BarnyShergold BarnyShergold

@omiroshnichenko omiroshnichenko

Labels
PAP Page Builder Partner: Vaimo https://www.vaimo.com Progress: done
Projects
Pull Request Progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer can style content types output differently per viewport
3 participants
@bluemwhitew @omiroshnichenko @BarnyShergold