New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] #558 #7 Developer can style content types output differently per viewport - fix broken tests #627

Closed

lbvaimo wants to merge 146 commits into csso-alternative from 558_7_content-type-style-attribute-removal

lbvaimo commented Sep 11, 2020 •

edited by omiroshnichenko

Loading

Story

As a developer I want to easily create themes and customizations to existing Page Builder content types to enable me align their visual output with my desired theme

Business Value

ability to style content with CSS classes not using !important

Acceptance Criteria

Developers are no longer required to use !important to style CSS properties

Technical Vision

Remove the usage of style attributes
Utilize style block generation and include a single block per instance
Consider including an optimizer to further decrease the size of the payload: https://github.com/css/csso

Story

Related Pull Requests

https://github.com/magento/magento2-page-builder-ee/pull/173

Checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Lukasz Borowiec added 4 commits

September 10, 2020 15:17


          #558: Developer can style content types output differently per viewport

add184c

#7 - Added ValidateContentTypeStyles action group


          #558: Developer can style content types output differently per viewport

7666ea9

#7 - Added ValidateContentTypeStyles action group


          #558: Developer can style content types output differently per viewport

e923aa9

#7 - Added ValidateContentTypeStyles action group


          #512: User edits cms block content in full-screen mode only - fix Pag…

1d127c4

…eBuilderCatalogProductAddAndEditRowColumnSlideTest test

lbvaimo changed the base branch from develop to csso-alternative

September 11, 2020 11:50

lbvaimo changed the title ~~558 7 content type style attribute removal~~ [Story] Developer can style content types output differently per viewport #7 fix broken tests

lbvaimo linked an issue

that may be closed by this pull request

Developer can style content types output differently per viewport #558

Closed

7 tasks

lbvaimo changed the title ~~[Story] Developer can style content types output differently per viewport #7 fix broken tests~~ #558 Developer can style content types output differently per viewport #7 fix broken tests

lbvaimo changed the title ~~#558 Developer can style content types output differently per viewport #7 fix broken tests~~ #558 [Story] #7 Developer can style content types output differently per viewport - fix broken tests

lbvaimo changed the title ~~#558 [Story] #7 Developer can style content types output differently per viewport - fix broken tests~~ [WIP] #558 #7 Developer can style content types output differently per viewport - fix broken tests

lbvaimo assigned hannahnida

m2-community-project bot unassigned hannahnida

lbvaimo assigned hannahnida

m2-community-project bot commented Sep 11, 2020

@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

lbvaimo self-assigned this

m2-community-project bot unassigned hannahnida and lbvaimo

m2-community-project bot commented Sep 11, 2020

@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

1 similar comment

m2-community-project bot commented Sep 11, 2020

@lbvaimo unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

lbvaimo added the PAP Page Builder label

m2-community-project bot added the Progress: review label

lbvaimo added 2.4-develop: exclude and removed Progress: review labels

m2-community-project bot added the Progress: review label

lbvaimo added Partner: Vaimo and removed Progress: review labels

m2-community-project bot added the Progress: review label

m2-community-project bot added the Progress: changes requested label

dhaecker and others added 7 commits

October 5, 2020 12:07


          MC-35402: [Page Builder] New top-level Full-Width and Full-Bleed comp…

e69228e

…onents are always nested in a Contained component

 - Fixing MFTF CR feedback


          MC-35402: [Page Builder] New top-level Full-Width and Full-Bleed comp…

31170da

…onents are always nested in a Contained component

 - Fixing filename


          Added wiki links to README.

7ee8471


          Merge branch 'bdenham_readme' of github.com:bdenham/magento2-page-bui…

7cdfba5

…lder into imported-magento-magento2-page-builder-631


          Merge pull request #1 from magento-obsessive-owls/imported-magento-ma…

e56edfd

…gento2-page-builder-631

[Imported] MC-35402: [Page Builder] New top-level Full-Width and Full-Bleed comp�


          Merge branch 'develop' into 558_7_content-type-style-attribute-removal

25eb396


          Changed names of groups, references on groups, added discription to n…

a96c673

…ew groups, changed name in Pascal caps format

Contributor

petrovsa commented Oct 8, 2020

@magento run Functional Tests EE


          #558: Developer can style content types output differently per viewport

1208f02

 - were updated ALL deprecated action groups

Contributor

petrovsa commented Oct 8, 2020

@magento run Functional Tests EE

1 similar comment

Contributor

petrovsa commented Oct 9, 2020

@magento run Functional Tests EE


          #558: Developer can style content types output differently per viewport

d38e3ee

 - fixed bugs in test generation and changed all references on groups

Contributor

hannahnida commented Oct 9, 2020

@magento run Functional Tests EE

1 similar comment

Contributor

petrovsa commented Oct 12, 2020

@magento run Functional Tests EE


          #558: Developer can style content types output differently per viewport

6aa7d04

 - I changed references in PB-EE in PR 173
 - I made refactoring follow groups:
 ValidateAdvancedConfigurationWithAlignmentActionGroup
 ValidateAdvancedConfigurationWithBorderColorActionGroup
 ValidateAdvancedConfigurationWithCssClassesActionGroup
 ValidateAdvancedConfigurationWithNoAlignmentActionGroup
 ValidateAdvancedConfigurationWithNoAlignmentEmptyBorderRadiusActionGroup
 ValidateAdvancedConfigurationWithNoBorderActionGroup
 ValidateAdvancedConfigurationWithNoBorderRadiusActionGroup

Contributor

petrovsa commented Oct 12, 2020

@magento run Functional Tests EE

hannahnida added 2 commits

October 12, 2020 16:15


          #558: Developer can style content types output differently per viewpo…

ea104a1

…rt - Banner Content Type Mftf fixes


          Merge branch '558_7_content-type-style-attribute-removal' of magento/…

ce5edc5

…magento2-page-builder into 558_7_content-type-style-attribute-removal

Contributor

hannahnida commented Oct 12, 2020

@magento run Functional Tests EE

hannahnida and others added 3 commits

October 12, 2020 17:45


          #558: Developer can style content types output differently per viewpo…

44f4e36

…rt - Banner Content Type Mftf fixes


          #558: Developer can style content types output differently per viewport

a943edb

 - I made refactoring follow groups:
 ValidateAdvancedConfigurationWithNoBorderWidthActionGroup
 ValidateAdvancedConfigurationWithNoMarginsActionGroup
 ValidateAdvancedConfigurationWithNoPaddingActionGroup


          Merge remote-tracking branch 'origin/558_7_content-type-style-attribu…

63d3be1

…te-removal' into 558_7_content-type-style-attribute-removal

Contributor

petrovsa commented Oct 13, 2020

@magento run Functional Tests EE


          #558: Developer can style content types output differently per viewport

e4e69b2

 - I made refactoring follow groups:
 ValidateAdvancedConfigurationWithNoMarginsActionGroup
 ValidateBackgroundConfigurationWithNoImageActionGroup

Contributor

petrovsa commented Oct 13, 2020

@magento run Functional Tests EE

omiroshnichenko closed this

omiroshnichenko deleted the 558_7_content-type-style-attribute-removal branch

December 7, 2020 18:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.4-develop: exclude PAP Page Builder Partner: Vaimo Progress: changes requested