Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #558 #7 Developer can style content types output differently per viewport - Fix broken tests #651

Conversation

hannahnida
Copy link
Contributor

Description (*)

Developer can style content types output differently per viewport - Mftf tests fixes

Story

  • 558 Developer can style content types output differently per viewport

Related Pull Requests

https://github.com/magento/magento2-page-builder-ee/pull/174

Manual testing scenarios (*)

Test plan added in story: #558

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Lukasz Borowiec and others added 30 commits September 10, 2020 15:17
…rt #7 - Added ValidateContentTypeStyles action group
…rt #7 - Added ValidateContentTypeStyles action group
…rt #7 - Added ValidateContentTypeStyles action group
…eBuilderCatalogProductAddAndEditRowColumnSlideTest test
…eBuilderCatalogProductAddAndEditRowColumnSlideTest test
…output differently per viewport - Mftf tests fixes
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Added new action group fo Divider
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Mftf tests fixes
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Mftf tests fixes
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Mftf text fixes
…output differently per viewport - Mftf text fixes for width values
…onents are always nested in a Contained component
…output differently per viewport - Mftf text fixes
…onents are always nested in a Contained component
…output differently per viewport - Fixed Mftf divider tests
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Fixed advanced configuration action groups
hannahnida and others added 4 commits October 15, 2020 15:43
…output differently per viewport - General Mftf tests fixes
…output differently per viewport

 - ancestorPath was deleted and references changed on it
…output differently per viewport - General Mftf tests fixes
…da/magento2-page-builder into 558_7_content-type-style-attribute-removal
@hannahnida
Copy link
Contributor Author

@magento run Functional Tests EE

…output differently per viewport - General Mftf tests fixes
@hannahnida
Copy link
Contributor Author

@magento run Functional Tests EE

petrovsa and others added 4 commits October 16, 2020 11:36
…output differently per viewport

 - fix ValidateAdvancedConfigurationWithNoBorderActionGroup
…output differently per viewport - Slider min-height fixes
…output differently per viewport - General Mftf fixes
@hannahnida
Copy link
Contributor Author

@magento run Functional Tests EE

…output differently per viewport - Added new step
@hannahnida
Copy link
Contributor Author

@magento run Functional Tests EE

…output differently per viewport

 - fix BlockRenderSlideItemPosterAppearanceThroughBlockContentTypeTest
@petrovsa
Copy link
Contributor

@magento run Functional Tests EE

@hannahnida
Copy link
Contributor Author

@magento run all tests

@hannahnida hannahnida requested a review from dhaecker October 19, 2020 12:10
@dhaecker
Copy link
Contributor

@hannahnida @omiroshnichenko Unit test failure looks relevant

@omiroshnichenko
Copy link
Contributor

@magento run Unit Tests

…output differently per viewport

- fix unit test
@omiroshnichenko
Copy link
Contributor

@magento run Unit Tests

@omiroshnichenko omiroshnichenko merged commit 88e60f3 into magento:csso-alternative Oct 19, 2020
@omiroshnichenko
Copy link
Contributor

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Developer can style content types output differently per viewport
7 participants