-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] #558 #7 Developer can style content types output differently per viewport - Fix broken tests #651
Merged
omiroshnichenko
merged 187 commits into
magento:csso-alternative
from
hannahnida:558_7_content-type-style-attribute-removal
Oct 19, 2020
Merged
[WIP] #558 #7 Developer can style content types output differently per viewport - Fix broken tests #651
omiroshnichenko
merged 187 commits into
magento:csso-alternative
from
hannahnida:558_7_content-type-style-attribute-removal
Oct 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt #7 - Added ValidateContentTypeStyles action group
…rt #7 - Added ValidateContentTypeStyles action group
…rt #7 - Added ValidateContentTypeStyles action group
…eBuilderCatalogProductAddAndEditRowColumnSlideTest test
…eBuilderCatalogProductAddAndEditRowColumnSlideTest test
…ixes for red tests
…output differently per viewport - Mftf tests fixes
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…ixes for red tests
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…ixes for red tests
…ixes for red tests
…ixes for red tests
…output differently per viewport - Added new action group fo Divider
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Mftf tests fixes
…ixes for red tests
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…ixes for red tests
…output differently per viewport - Mftf tests fixes
…magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Mftf text fixes
…output differently per viewport - Mftf text fixes for width values
…onents are always nested in a Contained component
…output differently per viewport - Mftf text fixes
…onents are always nested in a Contained component
…output differently per viewport - Fixed Mftf divider tests
…ixes for red tests
…om:magento/magento2-page-builder into 558_7_content-type-style-attribute-removal
…output differently per viewport - Fixed advanced configuration action groups
…output differently per viewport - General Mftf tests fixes
…output differently per viewport - ancestorPath was deleted and references changed on it
…output differently per viewport - General Mftf tests fixes
…da/magento2-page-builder into 558_7_content-type-style-attribute-removal
@magento run Functional Tests EE |
…output differently per viewport - General Mftf tests fixes
@magento run Functional Tests EE |
…output differently per viewport - fix test
…output differently per viewport - fix ValidateAdvancedConfigurationWithNoBorderActionGroup
…output differently per viewport - Slider min-height fixes
…output differently per viewport - General Mftf fixes
@magento run Functional Tests EE |
…output differently per viewport - Added new step
@magento run Functional Tests EE |
…output differently per viewport - fix BlockRenderSlideItemPosterAppearanceThroughBlockContentTypeTest
@magento run Functional Tests EE |
@magento run all tests |
dhaecker
approved these changes
Oct 19, 2020
@hannahnida @omiroshnichenko Unit test failure looks relevant |
… output differently per viewport - fix unit test
magento/magento2-page-builder#558: Developer can style content types…
@magento run Unit Tests |
…output differently per viewport - fix unit test
@magento run Unit Tests |
m2-community-project
bot
added
Progress: done
and removed
Progress: changes requested
labels
Oct 19, 2020
@magento run all tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.4-develop: exclude
2.4-develop: exclude
PAP Page Builder
Partner: Vaimo
https://www.vaimo.com
Progress: done
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Developer can style content types output differently per viewport - Mftf tests fixes
Story
Related Pull Requests
https://github.com/magento/magento2-page-builder-ee/pull/174
Manual testing scenarios (*)
Test plan added in story: #558
Questions or comments
Checklist