Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to add content-type inside Slide component #874

Closed
wants to merge 2 commits into from

Conversation

dadolun95
Copy link

Description (*)

The purpose of this pull request is to add a new "slide" component appearance called "container" as requested inside issue #384
This new appearance allow the user to insert content-type elements inside any slide.

Story

  • #384 User adds content types into Slide

Manual testing scenarios (*)

  1. Create a "Row" content type inside a CMS content
  2. Place "Slider" content inside
  3. Edit the first slide clicking on the Slider dots
  4. Choose "Container" appearance
  5. Save the slide
  6. Place other content-type elements inside the slide

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dadolun95,

Please sign the CLA and also please fix the failed tests.

Thanks

@engcom-Hotel
Copy link
Collaborator

Hello @dadolun95,

We have noticed that this PR has not been updated for a long time. Hence we are closing this PR for now.

Let us know when you are ready to work on it again, and we will be happy to re-open it. Thank you for your contribution!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Community Picked PRs upvoted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User adds content types into Slide
3 participants