-
Notifications
You must be signed in to change notification settings - Fork 104
406: added sorting plugin list marker #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bohdan-harniuk
merged 7 commits into
magento:4.4.0-develop
from
korovitskyi:406-sorting-plugin-marker
Aug 23, 2022
Merged
406: added sorting plugin list marker #1121
bohdan-harniuk
merged 7 commits into
magento:4.4.0-develop
from
korovitskyi:406-sorting-plugin-marker
Aug 23, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3d79d3
to
7b9579a
Compare
7b9579a
to
4656c8a
Compare
…plugin into 406-sorting-plugin-marker
…plugin into 406-sorting-plugin-marker
3b2f0fe
to
dc2100e
Compare
dc2100e
to
9e2cde5
Compare
bohdan-harniuk
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
It was added by sorting the plugin parkers depending on it's "before" "around" or "after" plugin, and by the sortOrder attribute value.
But it was not included in sorting by the module sequence. Here we should add the parsing
config.php
file and provide an array with the module name and sequence value. Please to implement it was added the note@TODO
at the thecom.magento.idea.magento2plugin.linemarker.php.PluginLineMarkerProvider.PluginClassCache#getPluginMethods(java.util.List<com.magento.idea.magento2plugin.stubs.indexes.data.PluginData>)
Actual results:
In the first file, you can see the list sorted by sortOrder value and the correct list for the
after
plugin after around.In the second file, you can see that the vendor plugin, which has no
sortOrder
attribute has the highest priority.2022-06-28.21.33.04.mov
Questions or comments
To compleat this part we here need add the module sequence condition: the logic to sort is implemented, need just add module sequence value.
Also in the future will be good mark the area of plugins list:
Contribution checklist (*)