Skip to content

406: added sorting plugin list marker #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

korovitskyi
Copy link
Contributor

Description (*)
It was added by sorting the plugin parkers depending on it's "before" "around" or "after" plugin, and by the sortOrder attribute value.

But it was not included in sorting by the module sequence. Here we should add the parsing config.php file and provide an array with the module name and sequence value. Please to implement it was added the note @TODO at the the com.magento.idea.magento2plugin.linemarker.php.PluginLineMarkerProvider.PluginClassCache#getPluginMethods(java.util.List<com.magento.idea.magento2plugin.stubs.indexes.data.PluginData>)

Actual results:
In the first file, you can see the list sorted by sortOrder value and the correct list for the after plugin after around.
In the second file, you can see that the vendor plugin, which has no sortOrder attribute has the highest priority.

2022-06-28.21.33.04.mov

Questions or comments
To compleat this part we here need add the module sequence condition: the logic to sort is implemented, need just add module sequence value.

Also in the future will be good mark the area of plugins list:

  • around before/after proceed;
  • methods wich where disabled or not working, because callable was not callable.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@korovitskyi korovitskyi force-pushed the 406-sorting-plugin-marker branch from 7b9579a to 4656c8a Compare June 29, 2022 20:45
@bohdan-harniuk bohdan-harniuk linked an issue Aug 23, 2022 that may be closed by this pull request
@bohdan-harniuk bohdan-harniuk force-pushed the 406-sorting-plugin-marker branch from 3b2f0fe to dc2100e Compare August 23, 2022 10:27
@bohdan-harniuk bohdan-harniuk force-pushed the 406-sorting-plugin-marker branch from dc2100e to 9e2cde5 Compare August 23, 2022 10:34
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @korovitskyi !

Great work!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier navigation through plugins
2 participants