1105 add graphQL schema file creation action #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinMykola
force-pushed
the
1105-add-graphql-schema-file-create-action
branch
from
b9f3351 to
f24d7e9
Compare
SilinMykola
force-pushed
the
1105-add-graphql-schema-file-create-action
branch
from
f24d7e9 to
26b4206
Compare
bohdan-harniuk
requested changes
Jul 1, 2022
| public class GraphQLSchemaGenerator extends FileGenerator { | ||
|
|
||
| private final String moduleName; | ||
|
|
There was a problem hiding this comment.
Please, remove unnecessary empty line.
| */ | ||
| public GraphQLSchemaGenerator( | ||
| final String moduleName, | ||
| final Project project) { |
There was a problem hiding this comment.
Please, reformat constructor:
Suggested change
| final Project project) { | |
| final Project project | |
| ) { |
| import com.intellij.lang.Language; | ||
| import com.jetbrains.php.lang.PhpLanguage; | ||
|
|
||
| public class GraphQLSchema implements ModuleFileInterface { |
There was a problem hiding this comment.
All file models should have suffix File
|
|
||
| @Override | ||
| public Language getLanguage() { | ||
| return PhpLanguage.INSTANCE; |
There was a problem hiding this comment.
Why did you use PhpLanguage.INSTANCE?
| import com.magento.idea.magento2plugin.actions.generation.generator.util.FindOrCreateGraphQLSchema; | ||
| import java.util.Properties; | ||
|
|
||
| public class GraphQLSchemaGenerator extends FileGenerator { |
There was a problem hiding this comment.
Where did you use this generator?
There was a problem hiding this comment.
@bohdan-harniuk Hi! Thanks for your review. I fixed. Please, check. Thanks!
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: review
Progress: changes requested
labels
SilinMykola
force-pushed
the
1105-add-graphql-schema-file-create-action
branch
from
708047f to
23eb924
Compare
SilinMykola
force-pushed
the
1105-add-graphql-schema-file-create-action
branch
from
23eb924 to
0021f42
Compare
bohdan-harniuk
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added ability to create a
schema.graphqlsfile from the action menu.Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)