Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed plugin generation sort order requirement #389

Merged
merged 5 commits into from
Nov 18, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 11, 2020

Description

This PR

  • makes the requirement of the sortOrder field in the 'create a new plugin' generation dialog, optional.
  • sets the default value as empty as recommended in the reported issue.
  • generates the sortOrder attribute in the di.xml plugin declaration only if sort order was initially set and no empty.
  • adds test case for scenario with no empty sort order field (sort order attribute should not be generated in XML file)

Fixed Issues

  1. Fixes Create Plugin action should default to no sortOrder #385: Create Plugin action should default to no sortOrder

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus merged commit a4ad38d into magento:2.1.0-develop Nov 18, 2020
@coderimus
Copy link
Contributor

Hello @drpayyne
Thank you for your contribution. According to the points policy, your contribution can be awarded with the next list of awards:

  • test coverage - Test coverage - Contribution contains a fix or improvement and new tests or test cases. -> here you change the tests
  • bug fix - Contribution fixes one or more known GitHub issues. -> you fixed the incorrect plugin sort order according to the report
    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Plugin action should default to no sortOrder
4 participants